Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xlogy #22740

Merged
merged 10 commits into from
Sep 18, 2023
Merged

xlogy #22740

merged 10 commits into from
Sep 18, 2023

Conversation

NiteshK84
Copy link
Contributor

@NiteshK84 NiteshK84 commented Aug 29, 2023

PR Description

Adds xlogy function to torch frontend

Related Issue

Close #21869

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you follow the steps we provided?

Socials:

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Aug 29, 2023
@aparajith21
Copy link
Contributor

aparajith21 commented Aug 30, 2023

Hi, thank you for contributing! There appear to be some failures on the CI. Could you please check these locally and see what shows up there. Further, it would be great if you could check off the items in the front end checklist by commenting add_frontend_checklist and confirm everything has been completed properly, and also resolve merge conflicts before requesting review. Thanks for taking the time and contributing!

@aparajith21
Copy link
Contributor

Please close this one as it seems to be a repeat of another PR you created! Thanks

@NiteshK84
Copy link
Contributor Author

NiteshK84 commented Sep 4, 2023

Please close this one as it seems to be a repeat of another PR you created! Thanks

Hey @aparajith21,
actually this is not a clone
the other PR implements the inplace version of this function, it must be suffix with an underscore, which ever other PR you confused with,
i'll fix the merge conflicts here please review and merge it
Thanks 😄

@NiteshK84
Copy link
Contributor Author

@aparajith21, i fixed merge conflicts,
its ready to merge.

@NiteshK84
Copy link
Contributor Author

ready!

@aparajith21
Copy link
Contributor

LGTM! Thanks for contributing

@aparajith21 aparajith21 merged commit 93136f2 into ivy-llc:main Sep 18, 2023
397 checks passed
iababio pushed a commit to iababio/ivy that referenced this pull request Sep 27, 2023
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xlogy
3 participants