Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added paddle.stft function frontend and test for it #23301

Closed
wants to merge 9 commits into from
Closed

added paddle.stft function frontend and test for it #23301

wants to merge 9 commits into from

Conversation

Boghdady9
Copy link
Contributor

@Boghdady9 Boghdady9 commented Sep 8, 2023

PR Description

This commit adds a new function, short_DFT, to the codebase. The short_DFT function allows for the computation of the Short-Time Fourier Transform (STFT) using PaddlePaddle. It supports various parameters for customization, such as windowing, padding, and normalization. You can find the function in ivy/functional/frontends/paddle/fft.py

also I adds a test function, test_paddle_short_DFT, which tests the short_DFT function in the paddle.signal module. The test cases cover different input shapes and parameters, ensuring the correctness of the short_DFT function.

Related Issue

Close #23281
you can find my solution in files changed section in both fft.py and test_signal.py

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you follow the steps we provided?

Socials:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Sep 8, 2023
@Boghdady9
Copy link
Contributor Author

@juliagsy
I deleted both
[ivy/functional/frontends/paddle/nn/functional/norm.py]
[ivy_tests/test_ivy/test_frontends/test_paddle/test_nn/test_functions.py]

because I was working on them in different task and they appeared in the Files changed section for this PR, so I deleted them till pull got merged. it was unexpected mistake, sorry!

@Boghdady9
Copy link
Contributor Author

@juliagsy Hello, I need a review

@Boghdady9 Boghdady9 closed this by deleting the head repository Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

< stft >
3 participants