-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added quantile function #23541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
@lucasalavapena Would really be appreciable and great if you can look into this PR soon! Thanks! |
If you are working on an open task, please edit the PR description to link to the issue you've created. For more information, please check ToDo List Issues Guide. Thank you 🤗 |
HI @ivy-leaves I have added the issue number to this PR. Can you review it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaskiratsingh2000 Thanks for your PR!
Could you please follow what the linter (which you would also get if you use codespaces or setup precommit) asked you to do in https://github.com/unifyai/ivy/actions/runs/6175112494/job/16761260862?pr=23541 (it just orders the function per alphabetical name IIRC). Also your tests do not work, handle_frontend_test
was never imported. I added it and still got:
===================================================================================== 0.0% of 5 passed ===================================================================================================================================================================== short test summary info =================================================================================
FAILED ivy_tests/test_ivy/test_frontends/test_paddle/test_tensor/test_tensor.py::test_paddle_quantile[cpu-numpy-False-False] - exceptiongroup.ExceptionGroup: Hypothesis found 2 distinct failures. (2 sub-exceptions)
FAILED ivy_tests/test_ivy/test_frontends/test_paddle/test_tensor/test_tensor.py::test_paddle_quantile[cpu-jax-False-False] - exceptiongroup.ExceptionGroup: Hypothesis found 2 distinct failures. (2 sub-exceptions)
FAILED ivy_tests/test_ivy/test_frontends/test_paddle/test_tensor/test_tensor.py::test_paddle_quantile[cpu-tensorflow-False-False] - exceptiongroup.ExceptionGroup: Hypothesis found 2 distinct failures. (2 sub-exceptions)
FAILED ivy_tests/test_ivy/test_frontends/test_paddle/test_tensor/test_tensor.py::test_paddle_quantile[cpu-torch-False-False] - exceptiongroup.ExceptionGroup: Hypothesis found 2 distinct failures. (2 sub-exceptions)
FAILED ivy_tests/test_ivy/test_frontends/test_paddle/test_tensor/test_tensor.py::test_paddle_quantile[cpu-paddle-False-False] - exceptiongroup.ExceptionGroup: Hypothesis found 2 distinct failures. (2 sub-exceptions)
============================================================================= 5 failed, 61 warnings in 35.79s =============================================================================
ivy_tests/test_ivy/test_frontends/test_paddle/test_tensor/test_tensor.py
Outdated
Show resolved
Hide resolved
Hi @lucasalavapena Thank you very much for reviewing it. I have made the changes and submitted back which you requested. Could you please review it now? |
@lucasalavapena I'm unable to understand why is the test for lint failing because I feel like I implemented it correct. |
This PR resolves iumplementing the quantile function which has been described as a part of issue no - #15045