Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardtanh #24152

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Hardtanh #24152

merged 2 commits into from
Sep 22, 2023

Conversation

samthakur587
Copy link
Contributor

@samthakur587 samthakur587 commented Sep 18, 2023

in this PR i have implemented the hardtanh activation function for ivy experimental api.

I have implemented the hardtanh activation function for the both ivy data class ivy.array and ivy.container with all the backend tensorflow , torch , jax, numpy, paddle. it is passing all the test cases. below i have ateched the s.s of result of tests.

image

Close #23688

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@ivy-leaves ivy-leaves added Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request PaddlePaddle Backend Developing the Paddle Paddle Backend. Ivy Functional API labels Sep 18, 2023
@ZoeCD ZoeCD merged commit 139d9b5 into ivy-llc:main Sep 22, 2023
631 of 677 checks passed
@ZoeCD
Copy link
Contributor

ZoeCD commented Sep 22, 2023

Thank you so much for your contribution! 😊

@@ -933,3 +933,137 @@ def elu(
map_sequences=map_sequences,
out=out,
)

@staticmethod
def _static_hardtaanh(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change to _static_hardtanh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API PaddlePaddle Backend Developing the Paddle Paddle Backend.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hardtanh
4 participants