feat: added log10 function in paddle frontend #24461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on making your first Pull Request and thanks for supporting Ivy! 🎉
Join the conversation in our Discord
Here are some notes to understand our tests:
- We have merged all the tests in one file called `display_test_results` job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that fails on this PR.
Please make sure they are passing. 💪
Keep in mind that we will assign an engineer for this task and they will look at it based on the workload that they have, so be patient.
mokshmalik5757
changed the title
ivy-leaves
added
the
Paddle Frontend
Aarsh2001
suggested changes
Sep 26, 2023
|
Can you please give me some more details regarding why am i failing those tests, and what can i do fix those? |
Aarsh2001
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Hey @mokshmalik5757, I think the test logs were related to a missing import, tried running your test locally and everything seems fine. This PR is a good merge !
iababio
pushed a commit
to iababio/ivy
that referenced
this pull request
Sep 27, 2023
druvdub
pushed a commit
to druvdub/ivy
that referenced
this pull request
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
In this PR, I have added the function for implementing log10 function in the paddle frontend, and also wrote the test for the same.
Close #23911
Checklist
Socials: