feat: Add broadcast_tensors method to paddle.tensor.Tensor #25926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tinny-Robot
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on making your first Pull Request and thanks for supporting Ivy! 🎉
Join the conversation in our Discord
Here are some notes to understand our tests:
- We have merged all the tests in one file called `display_test_results` job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that fails on this PR.
Please make sure they are passing. 💪
Keep in mind that we will assign an engineer for this task and they will look at it based on the workload that they have, kindly be patient 😄.
Tinny-Robot
changed the title
ivy-leaves
added
the
Paddle Frontend
hmahmood24
requested changes
Sep 24, 2023
There was a problem hiding this comment.
Hey @Tinny-Robot, thanks a lot for the PR. Couple of points to address.
- Can you please remove the
.ipynb_checkpointsfolders that you committed to this PR? They are not needed - Plenty of lint issues with the PR. Can you please fix them using
pre-commit? - Make sure you run your test locally using
pytestto ensure it runs and passes for all backends.
Kindly request a re-review from me once done. Thanks! :)
Comment on lines
+1116
to
+1121
| @with_supported_dtypes( | ||
| {"2.5.1 and below": ("float16", "float32", "float64", "int8", "int16", "int32", "int64")}, | ||
| "paddle", | ||
| ) | ||
| def broadcast_tensors(self, name=None): | ||
| return paddle_frontend.Tensor(ivy.broadcast_arrays(self._ivy_array)) |
There was a problem hiding this comment.
This block of code was not supposed to be added to this file. Can you remove this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Changes Made
Added the
broadcast_tensorsfunction to thepaddle.tensor.tensor.Tensorclass and included the equivalent test case.Details
broadcast_tensorsmethod to enable broadcasting operations for tensors in thepaddle.tensor.tensor.Tensorclass.This PR enhances the capabilities of the
paddle.tensor.tensor.Tensorclass by introducing thebroadcast_tensorsmethod and ensures its correctness through testing.Related Issue
Close #25869
Checklist
Socials: