Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement add #25940

Merged
merged 5 commits into from
Dec 9, 2023
Merged

feat: implement add #25940

merged 5 commits into from
Dec 9, 2023

Conversation

ArsalanAli915
Copy link
Contributor

@ArsalanAli915 ArsalanAli915 commented Sep 23, 2023 •
edited
Loading

Close #25938

PR Description

Related Issue

Close #

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials:

github-actions[bot]
github-actions bot reviewed Sep 23, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Sep 23, 2023
@ArsalanAli915
Copy link
Contributor Author

@ZoeCD Please check the PR. It's passing all the tests and pre-commits. Please let me know If anything is needed.

@ZoeCD
Copy link
Contributor

ZoeCD commented Sep 29, 2023

Hello!
Thank you for your contribution!
Please change the PR title to follow the title convention. Also, you added the function add but your PR mentioned the function add_
Tests are not passing, you can see the results under the Details section of intelligent-tests-pr / run_tests (1) (pull_request)

Thanks!

@ArsalanAli915 ArsalanAli915 changed the title add_ add Oct 2, 2023
@ArsalanAli915
Copy link
Contributor Author

ArsalanAli915 commented Oct 2, 2023 •
edited
Loading

Thank you very much for giving the review on PR. I have changed the PR name from add_ to add. Also, according to ivy doc intelligent-tests-pr / run_tests (1) (pull_request) can ignored. Also, I have attached the SS which shows that the tests are passing successfully. Still, if there is anything I am missing, I am happy to make changes.
d2

@ArsalanAli915 ArsalanAli915 changed the title add feat: implement add Oct 2, 2023
@ArsalanAli915
Copy link
Contributor Author

@ZoeCD @ivy-leaves @thecoder12 could you please add the Hacktoberfest label to my pr? thanks.

@ArsalanAli915
Copy link
Contributor Author

@ZoeCD Could u please check the PR. its been a while now.

@ArsalanAli915
Copy link
Contributor Author

@ZoeCD please look into the PR?

@NripeshN
Merge remote-tracking branch 'upstream/main' into pr/25940
c96ce1e
@NripeshN
Refactor test_tensor.py and remove unused code
fa89c86 
(#PR1234)

Simplify the test_tensor.py file by removing unused code and adding a
new function. The removed code was commented out and no longer needed,
improving code readability. This change also aligns with code
conventions. This commit is part of pull request ivy-llc#1234.
@NripeshN NripeshN merged commit 3c7917f into ivy-llc:main Dec 9, 2023
132 of 140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@ZoeCD ZoeCD

Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add
5 participants
@ArsalanAli915 @ZoeCD @NripeshN @ivy-leaves @ivy-branch