feat: Add broadcast_tensors method to paddle.tensor.Tensor #26216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivy-leaves
added
the
Paddle Frontend
|
Hello, @YushaArif99. |
|
@YushaArif99 |
YushaArif99
reviewed
Oct 3, 2023
| }, | ||
| "paddle", | ||
| ) | ||
| def logical_xor(self, y, out=None, name=None): |
There was a problem hiding this comment.
why have you implemented logical_xor when the PR is about broadcast_tensors ?
YushaArif99
requested changes
Oct 3, 2023
There was a problem hiding this comment.
Hi @Tinny-Robot
It seems you've implemented a different function (logical_xor) and written a test for a different function (broadcast_tensor). The tests are also failing here with the following error:
E AttributeError: type object 'Tensor' has no attribute 'broadcast_tensors'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Changes Made
Added the
broadcast_tensorsfunction to thepaddle.tensor.tensor.Tensorclass and included the equivalent test case.Details
broadcast_tensorsmethod to enable broadcasting operations for tensors in thepaddle.tensor.tensor.Tensorclass.This PR enhances the capabilities of the
paddle.tensor.tensor.Tensorclass by introducing thebroadcast_tensorsmethod and ensures its correctness through testing.Related Issue
Close #25869
Checklist