feat(paddle Bucketize):adding test function for bucketize #26665
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Protected Branch
In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
|
Thank you for this PR, here is the CI results: This pull request does not result in any additional test failures. Congratulations! |
also with test function
boopathiviky
changed the title
ivy-leaves
added
the
Paddle Frontend
There was a problem hiding this comment.
Hi @boopathiviky, thank you for contributing! Overall looks good, just left a couple minor comments. Besides that, could you revert the changes you PR make to the misc.xml and _template__of_py_test.xml files ? Also, please make sure the tests pass locally as the intelligent tests are currently unstable and in the process of being fixed. Thanks!
| {"2.5.1 and below": ("float32", "float64", "int32", "int64")}, | ||
| "paddle", | ||
| ) | ||
| def bucketize(self, y, right=False, name=None): |
There was a problem hiding this comment.
We probably want to keep consistent signatures so I guess using sorted_sequence instead of y would make more sense, same for addingout_int32
There was a problem hiding this comment.
Thanks for your comments. All the changes are made and please have look.
| test_flags, | ||
| ): | ||
| dtype, input = dtype_and_values | ||
| input[0] = np.sort(input[0]) |
There was a problem hiding this comment.
Why is this sorting needed ?
There was a problem hiding this comment.
yes, this not used so for by mistake this could happen. i made changes pls have a look.
This reverts commit 43023d6.
tesnor.py and test_search.py
|
Looks good, as a final point, could you: |
Bucketize instance is removed in tensor.py file
|
All changes have made as per comment. kindly have look. |
adding bucketize to paddle tensor
tensor file has been changed
|
Hey, thanks for making those changes! The tests seems to fail for all backends with this error |
|
Closing Stale PR |
PR Description
Related Issue
Close #
Checklist
Socials