Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add erfc to torch frontend #26991

Merged
merged 7 commits into from
Jul 11, 2024
Merged

feat: add erfc to torch frontend #26991

merged 7 commits into from
Jul 11, 2024

Conversation

G544
Copy link
Contributor

@G544 G544 commented Oct 13, 2023

PR Description

added erfc and erfc_ function to torch frontend

Related Issue

Close #26880

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Oct 13, 2023
@github-actions
Copy link
Contributor

Thank you for this PR, here is the CI results:


This pull request does not result in any additional test failures. Congratulations!

@aparajith21
Copy link
Contributor

Hi, Thanks for contributing! Please create different PRs for erfc and erfc_. They're different items on the todo list, and once this is done, request review again!

@G544
Copy link
Contributor Author

G544 commented Oct 25, 2023

Hello @aparajith21.
I removed erfc_ from this pr. Now there is only erfc. Please take a look.

@aparajith21
Copy link
Contributor

Tests look good, and PR is generally LGTM, however, please change the PR title to adhere to conventional commits standards as explained by the bot in an earlier commit and resolve linting errors, will merge after that!

@G544 G544 changed the title add erfc and erfc_ feat: add erfc to torch frontend Nov 3, 2023
@Sam-Armstrong Sam-Armstrong merged commit 1ef9b84 into ivy-llc:main Jul 11, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

erfc
6 participants