-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : (adeded the hardshrink to ivy experimental) #27012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
Thank you for this PR, here is the CI results: This pull request does not result in any additional test failures. Congratulations! |
Hi! @JPGoodale can you please review PR. it's passing all the test . hope it's ready to merge . 🚀 thanks |
hii @JPGoodale @KareemMAX still waiting for your review 😞 |
Hi @samthakur587, everything looks great, thank you for your contribution. |
adeded the hardshrink to ivy experimental with all the backend torch, tensorflow, paddle, numpy, jax.
passing all the test looking for review on docstring . here the local test result.
Closes #26094
Checklist