Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : (adeded the hardshrink to ivy experimental) #27012

Merged
merged 8 commits into from
Oct 24, 2023

Conversation

samthakur587
Copy link
Contributor

@samthakur587 samthakur587 commented Oct 14, 2023

adeded the hardshrink to ivy experimental with all the backend torch, tensorflow, paddle, numpy, jax.

passing all the test looking for review on docstring . here the local test result.

image

Closes #26094

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@ivy-leaves ivy-leaves added Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request PaddlePaddle Backend Developing the Paddle Paddle Backend. Ivy Functional API labels Oct 14, 2023
@github-actions
Copy link
Contributor

Thank you for this PR, here is the CI results:


This pull request does not result in any additional test failures. Congratulations!

@samthakur587
Copy link
Contributor Author

Hi! @JPGoodale can you please review PR. it's passing all the test . hope it's ready to merge . 🚀

thanks

@samthakur587
Copy link
Contributor Author

hii @JPGoodale @KareemMAX still waiting for your review 😞

@JPGoodale
Copy link
Contributor

Hi @samthakur587, everything looks great, thank you for your contribution.

@JPGoodale JPGoodale merged commit 70171b5 into ivy-llc:main Oct 24, 2023
131 of 137 checks passed
@samthakur587 samthakur587 deleted the hardshrink branch October 24, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API PaddlePaddle Backend Developing the Paddle Paddle Backend.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hardshrink
4 participants