Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ivy Failing Test: paddle - searching.where #28410

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

MuhammadNizamani
Copy link
Contributor

@MuhammadNizamani MuhammadNizamani commented Feb 24, 2024

PR Description

passing locally on 200 examples
paddle-where

Related Issue

Closes #28409

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MuhammadNizamani
Thank you for the PR :)
Note that with supported dtypes decorator means that these are the only suppported types. The functions seems to be trying to handle several other dtypes under

    if ret_dtype in [
        paddle.int8,
        paddle.int16,
        paddle.uint8,
        paddle.float16,
        paddle.bool,
    ]:

and also under

elif ret_dtype in [paddle.complex64, paddle.complex128]:

The decorator seems to have negated all these but the function is still trying to handle. Could we fix this? Let me know if something is unclear. Thanks :)

ivy/functional/backends/paddle/searching.py Outdated Show resolved Hide resolved
@MuhammadNizamani
Copy link
Contributor Author

@Ishticode sir first of all I love your work in IVY. and here is my argument , when I run paddle where function without decorator it says paddle where function support float32, float64, int32, int64. and I also checked paddlepaddle docs for it says the same thing.
docs link for paddlepaddle function
https://www.paddlepaddle.org.cn/documentation/docs/en/2.2/api/paddle/where_en.html#where
And this is SS for it .
paddle where datatypme

Thanks for the review

@MuhammadNizamani
Copy link
Contributor Author

MuhammadNizamani commented Mar 7, 2024

@Ishticode I have gone through again and I checked that float16 and bfloat16 keep failing so I just make them unsupported.
if anything I am missing please enlighten me.
Thanks for your informative response.
PS: tests are passing on 500 examples

Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MuhammadNizamani for your continous work :)

@Ishticode Ishticode merged commit bb0f46b into ivy-llc:main Mar 8, 2024
136 of 141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Ivy Failing Test: paddle - searching.where
3 participants