-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ivy Failing Test: paddle - searching.where #28410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MuhammadNizamani
Thank you for the PR :)
Note that with supported dtypes decorator means that these are the only suppported types. The functions seems to be trying to handle several other dtypes under
if ret_dtype in [
paddle.int8,
paddle.int16,
paddle.uint8,
paddle.float16,
paddle.bool,
]:
and also under
elif ret_dtype in [paddle.complex64, paddle.complex128]:
The decorator seems to have negated all these but the function is still trying to handle. Could we fix this? Let me know if something is unclear. Thanks :)
@Ishticode sir first of all I love your work in IVY. and here is my argument , when I run paddle where function without decorator it says paddle where function support Thanks for the review |
@Ishticode I have gone through again and I checked that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MuhammadNizamani for your continous work :)
PR Description
passing locally on 200 examples
Related Issue
Closes #28409
Checklist
Socials