fix: use primary get_item implementation for 1d tensor queries with tf, and added a test for partial_mixed_handler to check for this
#28456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ishticode
approved these changes
Mar 1, 2024
vedpatwardhan
suggested changes
Mar 1, 2024
There was a problem hiding this comment.
Hey @mattbarrett98, get_item seems to be failing with the tensorflow backend, could you please check if the failure's related to the changes made? Thanks and apologies for the delayed review 😅
vedpatwardhan
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
lgtm! Feel free to merge, thanks @mattbarrett98 @Ishticode 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets around an issue with kornia, where the compositional get_item is causing issues with tf.function (as well as efficiency issues)
Think i've found an even more efficient implementation by using tf.gather when the query is a tensor of any dimension, which will cause it to defer to the more efficient primary implementation for an even wider array of cases (assuming tests still work)