Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed tensorflow.math.softplus #28466

Merged
merged 5 commits into from
Mar 26, 2024
Merged

fixed tensorflow.math.softplus #28466

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bcb126c
fixed tensorflow.math.softplus
ZJay07 Mar 1, 2024
7c9eee6
skip float16 if backend is paddle
ZJay07 Mar 17, 2024
e18029f
proper fix
ZJay07 Mar 25, 2024
3b4bfcc
removed unecessary code
ZJay07 Mar 25, 2024
73497e6
Merge branch 'main' into fixing_test
ZJay07 Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ivy/functional/frontends/tensorflow/math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,6 +868,16 @@ def softmax(logits, axis=None, name=None):
return ivy.softmax(logits, axis=axis)


@with_supported_dtypes(
{
"2.15.0 and below": (
"float16",
"float32",
"float64",
)
},
"tensorflow",
)
@to_ivy_arrays_and_back
def softplus(features, name=None):
return ivy.softplus(features)
Expand Down
2 changes: 2 additions & 0 deletions ivy_tests/test_ivy/test_frontends/test_tensorflow/test_math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2858,6 +2858,8 @@ def test_tensorflow_softplus(
on_device,
):
input_dtype, x = dtype_and_x
if backend_fw == "paddle" and "float16" in input_dtype:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be specified as unsupported in paddle backends softplus implementation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot to update this, will fix it right away!

return
helpers.test_frontend_function(
input_dtypes=input_dtype,
backend_to_test=backend_fw,
Expand Down
Loading