Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(get-item): Use dynamic shape rather than static (x.shape) when possible in _parse_query #28489

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

hmahmood24
Copy link
Contributor

PR Description

Use dynamic shape when available rather than static x.shape e.g. when the backend is set as tensorflow in _parse_query, allows get_item to be compilable with tf.function

Related Issue

Closes #

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

…shape e.g. when the backend is set as tensorflow in _parse_query, allows get_item to be compilable with tf.function
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Protected Branch

In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.

@hmahmood24 hmahmood24 changed the title fix(get-item): Use dynamic shape rather than static when possible in _parse_query fix(get-item): Use dynamic shape rather than static (x.shape) when possible in _parse_query Mar 6, 2024
Copy link
Contributor

@vedpatwardhan vedpatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Feel free to merge, thanks @hmahmood24 😄

@hmahmood24 hmahmood24 merged commit 9048689 into ivy-llc:main Mar 7, 2024
141 of 281 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants