-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Frontend Failing Test: paddle - general_functions.tensorflow.clip_by_value #28668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ZJay07
Thanks for the PR.
I know you didn't specify float16 as unsupported in tf frontend clip_by_value
funtion as it was already there but it does support float16
So maybe remove that. Otherwise all is good
but that says "complex64" is not in supported dtypes. And it then lists the supported dtypes. You can see "half" listed in there which does refer to float16. |
Hey @Ishticode, just updated the fix, not sure why when I place |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks for the fix.
I have seen this before. Although complex
should automatically include both but there might be a bug that we should look into in the un/supported dtypes decorator. :)
PR Description
Paddle does not support some dtypes so handled that, not sure why
complex
is not supported, test were kinda flaky where sometimesjax
passes andnumpy
fails ortensorflow
passes andtorch
fails, all of them threw the same error (in the pic) sayingcomplex
is not supported, so added that to the unsupported dtypes.Related Issue
Close #28664
This is also a drive by fix for
Close #28681
Checklist
Socials