Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Frontend Failing Test: paddle - operators.jax.lax.ne #28728

Merged
merged 1 commit into from
May 1, 2024
Merged

Fix Frontend Failing Test: paddle - operators.jax.lax.ne #28728

merged 1 commit into from
May 1, 2024

Conversation

ZJay07
Copy link
Contributor

@ZJay07 ZJay07 commented Apr 3, 2024 •
edited
Loading

PR Description

Error was due to very small abs differences, where jax rounds down to 0 but paddlepaddle takes the value. Fix by limiting the smallest abs value that can be generated for testing

eg: -2.23517418e-08 and -1.49011612e-08, is labelled as False in paddle but True in jax

Related Issue

Close #28727

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

@ivy-leaves ivy-leaves added the JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist label Apr 3, 2024
@ZJay07 ZJay07 marked this pull request as ready for review April 3, 2024 18:02
Ishticode
Ishticode approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ZJay07 for the fix :)

@Ishticode Ishticode merged commit 14a6c2f into ivy-llc:main May 1, 2024
141 of 157 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ishticode Ishticode Ishticode approved these changes

Assignees

@Ishticode Ishticode

Labels
JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Frontend Failing Test: paddle - operators.jax.lax.ne
3 participants
@ZJay07 @Ishticode @ivy-leaves