Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Changed the way type-casting was done in the frontend. Previous implementation did not enforce keeping the input's dtype and paddle backend utilises type promotion in the function called by torch's frontend
.masked_fill()
. This resulted in the failure of dtype assertions and a failed paddle pytest. All of the backends use.where()
to get the same results astorch.masked_fill()
, with paddle's solution being probably a bit overcomplicated- but the tests for.where()
are passing, so I did not want to alter that.Potentially to-do:
.masked_fill()
for the superset behaviour (even torch backend uses.where()
when.masked_fill()
is called);.where()
.Related Issue
Closes #28437
Checklist
Socials