-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arctan_ #6454
arctan_ #6454
Conversation
@AnnaTz Done!Thanks for reviewing. |
Ok
…On Wed, 2 Nov, 2022, 6:08 pm AnnaTz, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In ivy/functional/frontends/torch/Tensor.py
<#6454 (comment)>:
> @@ -128,6 +128,10 @@ def _to_with_device(
def arctan(self, *, out=None):
return torch_frontend.arctan(self, out=out)
The test is still failing, but it's because arctan is not defined
correctly (not your fault obviously). Could you change this line to return
torch_frontend.atan(self, out=out)? In torch arctan is an alias for atan.
—
Reply to this email directly, view it on GitHub
<#6454 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANLS36OUF3OOMYAZPMVGZ4DWGJODBANCNFSM6AAAAAARTWIMC4>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
@AnnaTz Done! But its still failing |
@AnnaTz Done but now even the lint test is failing.I just cannot make out why its happening in case of almost all Pytorch Frontend instance methods |
@AnnaTz |
In some checks you need to expand |
closes #6553