[Fix] Remove reference to array_or_none() in torch frontend test
#9442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CatB1t, could you kindly review this PR? Thank you! |
ivy-leaves
added
the
PyTorch Frontend
jaketae
changed the title
array_or_none() in torch frontend testarray_or_none() in torch frontend test
CatB1t
suggested changes
Jan 6, 2023
ivy_tests/test_ivy/test_frontends/test_torch/test_loss_functions.py
Outdated
Show resolved
Hide resolved
ivy_tests/test_ivy/test_frontends/test_torch/test_loss_functions.py
Outdated
Show resolved
Hide resolved
|
Hello @CatB1t, thanks for the review! I've made changes as requested. Let me know if there's more to do! |
NouranYoussef
pushed a commit
to NouranYoussef/ivy
that referenced
this pull request
Feb 26, 2023
…vy-llc#9442) Co-authored-by: CatB1t <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As discussed in #9440, the torch frontend
test_loss_functions.pyincludes a reference to thehelpers.array_or_none()method, which was removed in commit c8d0524. This has been causing many CI runs to fail due to issues unrelated to the PR itself.Solution
The referenced commit introduces a fix via
st.one_of(). This PR also incorporates this fix to remove the illegal reference toarray_or_none(). Closes #9440.