Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): simplifies the ui tsup config #80

Merged
merged 5 commits into from
Jun 12, 2024
Merged

Conversation

ixahmedxi
Copy link
Owner

This PR aims to do the following:

  • Simplify the tsup config in the ui package by utilising globs in the exports field of the package.json file instead of verbose per file export.
  • Removes the need for pkg-types utilisation.
  • Removes unused & unnecessary functions from the utils package.

Copy link

changeset-bot bot commented Jun 12, 2024

🦋 Changeset detected

Latest commit: fb4a760

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@orbitkit/utils Patch
@orbitkit/ui Patch
@orbitkit/docs Patch
@orbitkit/marketing Patch
@orbitkit/web Patch
@orbitkit/api Patch
@orbitkit/assets Patch
@orbitkit/auth Patch
@orbitkit/eslint Patch
@orbitkit/storybook Patch
@orbitkit/tailwind Patch
@orbitkit/tsconfig Patch
@orbitkit/vite Patch
@orbitkit/core Patch
@orbitkit/db Patch
@orbitkit/env Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@imCorfitz
Copy link
Collaborator

We still use pkg-types in the utils and update-workspace.ts file. I think we previously used the hoisted package, so we should install it as devDep in the root package.json I reckon.

@ixahmedxi
Copy link
Owner Author

@imCorfitz good catch, fixed.

@ixahmedxi ixahmedxi merged commit 0bc1e1b into main Jun 12, 2024
7 checks passed
@ixahmedxi ixahmedxi deleted the ahmed/ui-tsup branch June 12, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants