Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: clean up dead imports #60

Closed
esqew opened this issue Oct 20, 2023 · 1 comment · Fixed by #84
Closed

Chore: clean up dead imports #60

esqew opened this issue Oct 20, 2023 · 1 comment · Fixed by #84
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@esqew
Copy link
Collaborator

esqew commented Oct 20, 2023

There are quite a few spots around the codebase where we have imports that aren't being used.

Since this is purely cosmetic & isn't a drag on performance (at least, not to my knowledge) this one will be prioritized pretty low.

Also a good first ticket for those so inclined to jump in.

@esqew esqew added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 20, 2023
@esqew
Copy link
Collaborator Author

esqew commented Oct 20, 2023

Flake8's got a list for us to go on:

$ python3 -m flake8 . --select=F401
./kenpompy/FanMatch.py:5:1: F401 'mechanicalsoup' imported but unused
./kenpompy/FanMatch.py:7:1: F401 'bs4.BeautifulSoup' imported but unused
./kenpompy/conference.py:6:1: F401 'mechanicalsoup' imported but unused
./kenpompy/conference.py:8:1: F401 're' imported but unused
./kenpompy/conference.py:9:1: F401 'bs4.BeautifulSoup' imported but unused
./kenpompy/conference.py:10:1: F401 'datetime' imported but unused
./kenpompy/misc.py:6:1: F401 'mechanicalsoup' imported but unused
./kenpompy/misc.py:8:1: F401 'bs4.BeautifulSoup' imported but unused
./kenpompy/summary.py:6:1: F401 'mechanicalsoup' imported but unused
./kenpompy/summary.py:9:1: F401 'bs4.BeautifulSoup' imported but unused
./tests/test_conference.py:1:1: F401 'pytest' imported but unused
./tests/test_conference.py:2:1: F401 'datetime' imported but unused
./tests/test_conference.py:4:1: F401 'pandas as pd' imported but unused
./tests/test_fanmatch.py:1:1: F401 'pytest' imported but unused
./tests/test_fanmatch.py:2:1: F401 'kenpompy.misc as kpmisc' imported but unused
./tests/test_fanmatch.py:4:1: F401 'pandas as pd' imported but unused
./tests/test_misc.py:3:1: F401 'kenpompy.FanMatch.FanMatch' imported but unused
./tests/test_misc.py:4:1: F401 'pandas as pd' imported but unused
./tests/test_summary.py:3:1: F401 'pandas as pd' imported but unused
./tests/test_team.py:5:1: F401 'pandas as pd' imported but unused

esqew added a commit that referenced this issue Nov 28, 2023
@esqew esqew linked a pull request Nov 28, 2023 that will close this issue
@esqew esqew removed the help wanted Extra attention is needed label Nov 28, 2023
@esqew esqew self-assigned this Nov 28, 2023
@esqew esqew closed this as completed in #84 Nov 29, 2023
esqew added a commit that referenced this issue Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
1 participant