Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NST% columns #89

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

nickostendorf
Copy link
Contributor

@nickostendorf nickostendorf commented Jan 27, 2024

New column mapping for get_teamstats(). Added missing NST% and NST% Rank

Before, A% and 3PA% were getting populated with the wrong values, and AdjOE values would not be present.

image

@j-andrews7
Copy link
Owner

Thanks, Nick. Any chance you also want to update the few tests for this?

@nickostendorf
Copy link
Contributor Author

Hey Jared, the test_get_teamstats(browser): seems to already include the NST% & Rank columns.

image

def test_get_teamstats(browser):
    expected = ['Louisville', 'ACC', '34.2', '177', '50.6', '161', '77.7', '8', '10.6', '272', '8.3', '101', 
               NST --> '9.2', '128', '53.6', '122', '43.7', '56']

Let me know if we would still want a separate test on just the NST value and rank.

@j-andrews7
Copy link
Owner

Oh, good look. Note sure how/when this got goofed then. I'll make a new release when I get a chance, thanks.

@j-andrews7 j-andrews7 merged commit 8061ce6 into j-andrews7:master Jan 29, 2024
0 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants