-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V0.4.0 release #98
base: master
Are you sure you want to change the base?
V0.4.0 release #98
Conversation
Refactor for new cloudflare requirements
Handle dates with no games in fanmatch data
Update docs
Looks like Also, another issue that cropped up this morning, kenpom updated the "Sorry, no games today" fanmatch message from "Sorry, no games today :(" to "Sorry, no games today ☹" (using an emoji). So I'll open a new PR to fix both of these issues. |
Adds `lxml` and fix for new no games fanmatch message
I was developing/testing on ubuntu and pop os so makes sense those tests passed. I don't currently have a windows machine so not really too sure where to go for the failures there. Curious as to whether the MacOS tests would have passed. It looks like cloudscraper's |
Yeah, we've also had just periodic failures of tests from Github actions due to login problems that sometimes would work on retry (which is what I'm doing now). If it fails again, will dig deeper. |
Yeah, so the first Windows set of tests passed on python 3.8, then failed on 3.9 due to the login issue. But on repeat, the 3.9 tests are now running. Frankly, may just catch the login issue in the tests and run it again if it hits. |
Not sure you can see this, but the fanmatch test is failing on MacOS. https://github.com/j-andrews7/kenpompy/actions/runs/11656227363/job/32490372111 Not sure why, seems like it's still pulling data even with a date with no games. |
It seems like a lot of small things are changing on the site for the start of the season. I have a script that has been pulling the fanmatch html everyday (how I caught the previous fanmatch change) and it looks like sometime in the past 12 ish hours the "Time" column has changed. If we re-run the Ubuntu and Windows tests they would fail. The tag used to point to a link that included the actual day the games were on, which is how the date checking was done before. Unfortunately that has been removed in favor of a simpler sort link that look like this: |
Update for predicted possessions and new date matching
Tests in actions did eventually pass after enough retries. Probably won't have time for a real review/release till the weekend. |
Rolls in fixes to #90, #94, #92, and #93 from @seankim658.
@esqew, if you want to take a look, this should make it easy. Most stuff looks fine to me, but I'll check with a closer eye when I get a chance. cloudflare stuff is the biggest concern.