Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#264 Removal of ogrexml. Unsure of whether I've caught everything, bu… #309

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

neph1
Copy link
Contributor

@neph1 neph1 commented Mar 19, 2022

…t it builds and loads. #264
I haven't tested this extensively, just checked that the SDK builds and loads. Anything particular?

@MeFisto94
Copy link
Member

I guess I am also targetting it for 3.5, which should be available "soon" :D (As soon as 3.4 is working, that is)

@tonihele tonihele added this to the 3.5 release milestone Apr 21, 2022
@tonihele
Copy link
Contributor

@MeFisto94 care to check this one?

Copy link
Member

@MeFisto94 MeFisto94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the only thing I am uncertain is/are the asset packs then.
Do we need to remove them, if there is no real use for them anymore?
Like isn't this world forge the only real implementation/use case?

@neph1
Copy link
Contributor Author

neph1 commented Sep 14, 2022

I thought AssetPacks were a generic implementation to distribute collections of assets? Just that noone ever used them.

@MeFisto94
Copy link
Member

True, I guess it's just the other way around: world forge was one of the reasons we had ogre import, I guess.
and yeah, makes sense to keep asset packs, maybe someday someone finds them useful

@neph1 neph1 merged commit c93da49 into jMonkeyEngine:master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants