Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace icons #385

Merged
merged 16 commits into from
Oct 23, 2022
Merged

Replace icons #385

merged 16 commits into from
Oct 23, 2022

Conversation

neph1
Copy link
Contributor

@neph1 neph1 commented Sep 13, 2022

A first installment of svg icons for core. Some difficult to find/make are still left. Each module then has its own set of icons, usually just a few. I've tried to stick to the theme/look of the old ones, but some liberty has been taken in a few cases.
Would have been nice to keep color and size outside the svg's, but not sure how to do that.

A bunch of empty merge commits refuse to go away. I'll squash this when merging.

#355

@tonihele
Copy link
Contributor

Cool cool. The licensing part is ok?

@tonihele
Copy link
Contributor

Cool cool. The licensing part is ok?

Ah on the javadoc. Yeah, looks to satisfy the requirements I suppose.

@neph1
Copy link
Contributor Author

neph1 commented Sep 13, 2022

I think we can probably put it somewhere more visible too. There seems to be some credits on the About page already, so maybe there. I don't know if we need to be more specific, though, like iconX by authorY.

@tonihele
Copy link
Contributor

I think we can probably put it somewhere more visible too. There seems to be some credits on the About page already, so maybe there. I don't know if we need to be more specific, though, like iconX by authorY.

Good idea, I don't think we need to be more specific.

@neph1
Copy link
Contributor Author

neph1 commented Sep 23, 2022

Baby steps.. I wonder though, before I spend time finding icons for it; should we keep "Texture Editor"? Wouldn't it be better to just link to something external?

@neph1
Copy link
Contributor Author

neph1 commented Sep 28, 2022

That should conclude SceneComposer and SceneViewer. I tried to get a more coherent look on the icons and also made them larger, since displays have higher resolution than 640x480 nowadays.
Screenshot from 2022-09-28 20-03-13
Edit: Damnit.. I see two more bitmaps in that screenshot..

@neph1
Copy link
Contributor Author

neph1 commented Oct 1, 2022

Unlike the bitmaps, the look and feel actually changes the colors of the svg. I had not anticipated that (but it is in essence a good thing?). I had unfortunately tested the colors on the vanilla look and feel, and not dark metal. The blue and yellow look ok, I think, but the green is a bit too saturated. I better retweak the colors.
image

@neph1
Copy link
Contributor Author

neph1 commented Oct 10, 2022

Hmm, I just updated all the colors to look better with the chosen LAF (sed ftw), but I see now that I did have a dark theme in the first screenshot too. I can't select DarkMonkey in the list. Not sure how to proceed.
On a sidenote, I just checked out DarkLaF in the list. A superior LaF imho. Not "compatible" with the color change, though. Is it only DarkMetal that distorts the colors? Because all the others seem to show them as they were intended.

@neph1 neph1 merged commit 9f7eaeb into jMonkeyEngine:master Oct 23, 2022
@neph1 neph1 deleted the replace_icons_4 branch May 6, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants