Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#324 - changes VarType to JComboBox with hardcoded values for Shader Node wizard #400

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

neph1
Copy link
Contributor

@neph1 neph1 commented Oct 18, 2022

Hope I didn't miss anything. I feel like those values should be available somewhere, but don't know where.
(Adding the default "float" to make the row visible. Very confusing otherwise and you tend to click on "Add" several times)

Fixes #324

@MeFisto94
Copy link
Member

Hmm, the VarTypes are openGL keywords. But then the parser probably has them as well.
However, I guess it's not too bad we're using a manual list.
One thing though: From the commit (and PR title) it's not clear that this is related to shader node variable type definitions

@neph1 neph1 changed the title #324 - changes Type to JComboBox with hardcoded values #324 - changes VarType to JComboBox with hardcoded values for Shader Node wizard Oct 25, 2022
@neph1 neph1 added this to the 3.6 milestone Jan 3, 2023
@neph1 neph1 removed this from the 3.6 milestone Mar 10, 2023
@neph1 neph1 merged commit e520e4c into jMonkeyEngine:master Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create ShaderNodeDefinition - "Type" could be drop down menu.
2 participants