Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/gradle template improvements #545

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Feature/gradle template improvements #545

merged 4 commits into from
Nov 13, 2023

Conversation

tonihele
Copy link
Contributor

@tonihele tonihele commented Nov 9, 2023

  • Update Gradle wrapper to 8.4 (to support Java 21 LTS)
  • Use application plugin for setting main class and all that
  • Make an effort to support Macs and LWJGL 3
  • Remove deprecated Gradle stuff

@tonihele
Copy link
Contributor Author

Should be good to go. If nothing else arises I'll self integrate this in 48h.

neph1
neph1 approved these changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@neph1 neph1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look into the mysterious zip-file, but cool! 🚀

@neph1 neph1 added this to the 3.6.1-sdk3 milestone Nov 11, 2023
@tonihele
Copy link
Contributor Author

I didn't look into the mysterious zip-file, but cool! 🚀

That should be the Gradle wrapper upgraded only. The actual build files and all that comes nowadays from the Freemarker template.

@tonihele tonihele merged commit 93440a2 into jMonkeyEngine:master Nov 13, 2023
1 check passed
@tonihele tonihele deleted the feature/gradle-template-improvements branch November 13, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neph1 neph1 neph1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.1-sdk4
Development

Successfully merging this pull request may close these issues.
2 participants
@tonihele @neph1