Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests / Examples need to be created #3

Open
jaboc83 opened this issue Aug 23, 2019 · 1 comment
Open

Tests / Examples need to be created #3

jaboc83 opened this issue Aug 23, 2019 · 1 comment
Labels
enhancement New feature or request
Milestone
Ready for Contrib...

Comments

@jaboc83
Copy link
Owner

jaboc83 commented Aug 23, 2019

I'd like to mirror the YNAB tests for now that live in the Ruby/JS sdks for consistency.

https://github.com/ynab/ynab-sdk-js/tree/master/test
https://github.com/ynab/ynab-sdk-ruby/tree/master/spec
@jaboc83 jaboc83 added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 23, 2019
@jaboc83 jaboc83 added this to the Ready for Contributors milestone Aug 23, 2019
@jaboc83
Copy link
Owner Author

jaboc83 commented Aug 25, 2019

Probably going to need to address #1 before this can really be done properly. I've started writing a couple tests as examples but I'm going to hold off on more until I make the mock. Talking with YNAB's dev team they seem interested in creating some kind of global mock, but I'm not sure if/when that might happen so considering using VCR or something else for now.

jaboc83 pushed a commit that referenced this issue Aug 25, 2019
#3 Started some tests/examples
c1278c7
jaboc83 pushed a commit that referenced this issue Aug 29, 2019
#3 Add some more examples and Synchronous versions
edda497
jaboc83 pushed a commit that referenced this issue Aug 30, 2019
#3 Added some more tests and test data
84d0264
jaboc83 pushed a commit that referenced this issue Sep 4, 2019
#3 Added a Create Transaction Test
e231691
@jaboc83 jaboc83 removed good first issue Good for newcomers help wanted Extra attention is needed labels Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Ready for Contributors
Development

No branches or pull requests
1 participant
@jaboc83