Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GSS authentication to pgproto3 #27

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

otan
Copy link
Contributor

@otan otan commented Apr 10, 2022

This commits adds the GSS protobufs.

@otan otan marked this pull request as draft April 10, 2022 23:39
@otan
Copy link
Contributor Author

otan commented Apr 10, 2022

Marking as draft right now until we get testing sorted out.

@otan otan force-pushed the add_gss_proto branch 2 times, most recently from 548503c to 6bb7be1 Compare April 11, 2022 00:13
@jackc
Copy link
Owner

jackc commented Apr 12, 2022

Is there some reason for the field name of Token? AuthenticationSASLContinue and AuthenticationSASLFinal have a similar opaque payload field called Data. Unless there is a special reason I'd prefer to keep the naming consistent.

Aside from that it looks fine so far.

@otan
Copy link
Contributor Author

otan commented Apr 12, 2022

Is there some reason for the field name of Token?

just what i saw the other library call it :') changed accordingly.

@otan otan marked this pull request as ready for review April 12, 2022 04:31
@otan
Copy link
Contributor Author

otan commented Apr 12, 2022

alright well, this is ready for review (and merge)!

@jackc jackc merged commit 175856f into jackc:master Apr 12, 2022
@jackc
Copy link
Owner

jackc commented Apr 12, 2022

LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants