Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: Fix for RSS feed is crashing the build #711

Closed
wants to merge 1 commit into from

Conversation

chamodshehanka
Copy link

Which problem is this PR solving?

Description of the changes

  • TBD

How was this change tested?

  • TBD

Checklist

Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for romantic-neumann-1959d7 failed.

Name Link
🔨 Latest commit 1234177
🔍 Latest deploy log https://app.netlify.com/sites/romantic-neumann-1959d7/deploys/666c1e7b8ebe270008683689

@yurishkuro
Copy link
Member

You can test changes locally with make develop.

To make the testing cycles faster I found it useful to delete most of content/docs/1.xx directories, e.g. leave only 1.58 (but obviously don't commit this way), so that hugo has much fewer pages to process.

@yurishkuro
Copy link
Member

And please make sure all commits are signed.

@chamodshehanka
Copy link
Author

You can test changes locally with make develop.

To make the testing cycles faster I found it useful to delete most of content/docs/1.xx directories, e.g. leave only 1.58 (but obviously don't commit this way), so that hugo has much fewer pages to process.

sure! I'll

@yurishkuro yurishkuro mentioned this pull request Jun 15, 2024
@yurishkuro
Copy link
Member

@chamodshehanka I couldn't push a fix to this PR because you did it from the main branch of your fork - I strongly advise against doing that in the future, always use dedicated branch.

The fix is in #713

@yurishkuro yurishkuro closed this Jun 15, 2024
yurishkuro added a commit that referenced this pull request Jun 15, 2024
## Which problem is this PR solving?
- Resolves #710 
- Replaces #711

## Description of the changes
- Remove the use of JSON proxy server, read RSS as XML directly
- Change field names accordingly

## How was this change tested?
- locally `make develop`

Signed-off-by: Yuri Shkuro <[email protected]>
@chamodshehanka
Copy link
Author

@chamodshehanka I couldn't push a fix to this PR because you did it from the main branch of your fork - I strongly advise against doing that in the future, always use dedicated branch.

The fix is in #713

my apologize for that. I won't do that in the future.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RSS feed is crashing the build
2 participants