Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate multiple values of same tag with comma #103

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

bocharovf
Copy link
Collaborator

Which problem is this PR solving?

Resolves #98

Short description of the changes

Store multiple different values of the same tag in a single key separated by comma. It allows us to find trace by any of the tag value (not only first one).

PROS:

  1. Ability to search any tag value
  2. Backward compability (no schema changes or update required).

CONS:

  1. Search for tag value containing comma will be incorrect (could be solved by parametrizing separator)

@bocharovf bocharovf merged commit a79c103 into jaegertracing:main Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search by error tag does not work
2 participants