This repository has been archived by the owner on May 23, 2024. It is now read-only.
[zipkin] Encode span IDs as full 16-hex strings #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gator Based on the openzipkin/b3-propagation specification, the SpanID and ParentSpanID are to be encoded as 16 lower-hex characters. jaegertracing#533 fixed this for TraceID, and fixed the SpanID.String() method, but did not update the Zipkin Propagator SpanID encoding. This fix uses SpanID.String() to ensure proper encoding of the SpanID and ParentSpandID within the Zipkin Propagator. Signed-off-by: Nathan Bowler <[email protected]>
yurishkuro
changed the title
yurishkuro
approved these changes
Oct 6, 2021
Codecov Report
@@ Coverage Diff @@
## master #601 +/- ##
=======================================
Coverage 88.58% 88.58%
=======================================
Files 61 61
Lines 3328 3328
=======================================
Hits 2948 2948
Misses 252 252
Partials 128 128
Continue to review full report at Codecov.
|
|
thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the openzipkin/b3-propagation specification, the SpanID and
ParentSpanID are to be encoded as 16 lower-hex characters.
#533 fixed this for TraceID, and fixed the SpanID.String() method, but did not update the Zipkin Propagator to use the fixed SpanID encoding.
This fix uses SpanID.String() to ensure proper encoding of the SpanID and ParentSpanID within the Zipkin Propagator.
Signed-off-by: Nathan Bowler [email protected]