This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
initTracer should pass options.traceId128bit #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #397 +/- ##
=========================================
Coverage ? 98.65%
=========================================
Files ? 50
Lines ? 2010
Branches ? 377
=========================================
Hits ? 1983
Misses ? 27
Partials ? 0
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Sep 16, 2019
src/configuration.js
Outdated
| @@ -191,6 +191,8 @@ export default class Configuration { | |||
| * @param {Object} [options.logger] - a logger (see ./_flow/logger.js) | |||
| * @param {Object} [options.tags] - set of key-value pairs which will be set | |||
| * as process-level tags on the Tracer itself. | |||
| * @param {boolean} [options.traceId128bit] - generate root span with a 128bit traceId. | |||
| * BaggageRestrictionManager API from ./baggage.js. | |||
There was a problem hiding this comment.
Oops )
Remove this line
Signed-off-by: Aleksei Androsov <[email protected]>
doochik
force-pushed
the
options-traceId128bit
branch
from
1ea07ae
to
ad6ce57
Compare
Iuriy-Budnikov
pushed a commit
to agile-pm/jaeger-client-node
that referenced
this pull request
Sep 25, 2021
* fix(plugin-http): ensure no leaks closes jaegertracing#397 Signed-off-by: Olivier Albertini <[email protected]> * fix: add @Flarna recommandations Signed-off-by: Olivier Albertini <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
128 bit traceid was added at #361
But I can't do like this
const tracer = require('jaeger-client').initTracer(config, { traceId128bit: true });.Short description of the changes
options.traceId128bittonew Tracer