This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
Do not apply adaptive sampler to child spans #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #410 +/- ##
==========================================
+ Coverage 98.81% 98.81% +<.01%
==========================================
Files 50 50
Lines 2023 2027 +4
Branches 379 381 +2
==========================================
+ Hits 1999 2003 +4
Misses 24 24
Continue to review full report at Codecov.
|
added 2 commits
October 21, 2019 23:18
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
vprithvi
reviewed
Oct 22, 2019
test/samplers/remote_sampler.js
Outdated
| sp0.setOperationName('op2'); | ||
| assert.isTrue(sp0.context().isSampled(), 'op2 should be sampled on the root span'); | ||
|
|
||
| let sp1 = tracer.startSpan('op1', 'op1 should not be sampled'); |
There was a problem hiding this comment.
Could we use more descriptive names? parent/child or some such?
vprithvi
reviewed
Oct 22, 2019
| return { sample: false, retryable: false, tags: outTags }; | ||
| } | ||
| let isSampled = this.isSampled(span.operationName, outTags); | ||
| // returning retryable=true since we can change decision after setOperationName(). |
There was a problem hiding this comment.
I think this is a bit confusing because we set retryable 'false' onSetOperationName - perhaps "the decision can change the first time setOperationName is called?"
vprithvi
approved these changes
Oct 22, 2019
added 2 commits
October 22, 2019 13:12
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Per-operation adaptive sampling should only apply to service endpoints, not to operation names of the inner/children spans. Recent changes (e.g. #380) broke that functionality and traces can now be sampled by the per-operation sampler triggering on children spans. This is a problem for adaptive sampling backend that only records operations from the root spans, meaning all child operations are getting the default probability, which may be higher than the calculated probabilities.
Short description of the changes