This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
Fix xorshift related deprection warning (resolves #422) #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #422 Signed-off-by: Oliver Salzburg <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #442 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 50 50
Lines 2035 2035
Branches 383 383
=======================================
Hits 2009 2009
Misses 26 26 Continue to review full report at Codecov.
|
oliversalzburg
changed the title
oliversalzburg
changed the title
slaveofcode
pushed a commit
to slaveofcode/jaeger-client-node
that referenced
this pull request
Oct 27, 2020
Fixes jaegertracing#422 Signed-off-by: Oliver Salzburg <[email protected]> Signed-off-by: Kresna <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #422
When applications that use this module start with recent Node versions, a deprecation warning relating to
Bufferis emitted. This is caused by the xorshift dependency.There may be other deprecated Buffer usages, but only the first one will be logged. So I'm starting here.
Short description of the changes
I upgraded xorshift to the lastest version, which doesn't make use of
Bufferat all (and also doesn't rely on new dependencies for compatibility).