This repository has been archived by the owner on May 18, 2020. It is now read-only.
Update to use new SPAN_STORAGE env var #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will need retesting once jenkins is back online. @kevinearls if you could let me know when to trigger, thanks. |
Signed-off-by: Gary Brown <[email protected]>
objectiser
force-pushed
the
storageenv
branch
from
01c8915
to
d1051ca
Compare
…e, which is backward compatible with 1.1 Signed-off-by: Gary Brown <[email protected]>
objectiser
force-pushed
the
storageenv
branch
from
d1051ca
to
6f30062
Compare
|
@pavolloffay I've tested this locally against elasticsearch and it all starts up fine. So think it can be merged. @kevinearls Might be good if you could confirm works? |
pavolloffay
approved these changes
Jan 12, 2018
|
@objectiser Sure, will confirm on Monday |
|
@kevinearls ok thanks, I'll merge for now but feel free to create an issue if any problem found. |
|
@objectiser I have run both the performance tests and a version of the template tests using both Cassandra and ElasticSearch, and everything is working correctly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gary Brown [email protected]