Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom labels for the deployable components in production strategy #2277

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

hiteshwani29
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • We are facing this error because labels generated in the selector fields are different from the labels in the template.metadata.labels. With this PR we are generating the same labels under both sections.

@openshift-ci
Copy link

openshift-ci bot commented Aug 1, 2023

Hi @hiteshwani29. Thanks for your PR.

I'm waiting for a jaegertracing member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iblancasa
Copy link
Collaborator

@hiteshwani29 the linting is failing. You can check what is failing with make ci USER=jaegertracing

Signed-off-by: hiteshwani29 <[email protected]>
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 70.58% and project coverage change: -0.11% ⚠️

Comparison is base (efe0d36) 87.68% compared to head (63c8e69) 87.58%.
Report is 1 commits behind head on main.

❗ Current head 63c8e69 differs from pull request most recent head 2c531c2. Consider uploading reports for the commit 2c531c2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2277      +/-   ##
==========================================
- Coverage   87.68%   87.58%   -0.11%     
==========================================
  Files         100      100              
  Lines        6985     7009      +24     
==========================================
+ Hits         6125     6139      +14     
- Misses        656      666      +10     
  Partials      204      204              
Files Changed Coverage Δ
pkg/inject/sidecar.go 93.55% <62.96%> (-3.15%) ⬇️
controllers/appsv1/deployment_webhook.go 85.32% <100.00%> (+0.27%) ⬆️
pkg/deployment/agent.go 100.00% <100.00%> (ø)
pkg/deployment/collector.go 100.00% <100.00%> (ø)
pkg/deployment/ingester.go 94.77% <100.00%> (ø)
pkg/deployment/query.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iblancasa iblancasa enabled auto-merge (squash) August 2, 2023 10:48
@hiteshwani29
Copy link
Contributor Author

/retest-required

@iblancasa iblancasa merged commit b98428c into jaegertracing:main Aug 2, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to specifying custom labels for the deployable components in production strategy
2 participants