Protect the platform behind a mutex #2278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n viper Signed-off-by: Israel Blancas <[email protected]>
Signed-off-by: Israel Blancas <[email protected]>
Signed-off-by: Israel Blancas <[email protected]>
Signed-off-by: Israel Blancas <[email protected]>
|
Skipping CI for Draft Pull Request. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2278 +/- ##
==========================================
+ Coverage 87.68% 87.71% +0.02%
==========================================
Files 101 102 +1
Lines 7129 7162 +33
==========================================
+ Hits 6251 6282 +31
- Misses 681 683 +2
Partials 197 197
☔ View full report in Codecov by Sentry. |
Signed-off-by: Israel Blancas <[email protected]>
rubenvp8510
approved these changes
Aug 23, 2023
frzifus
reviewed
Aug 28, 2023
| @@ -68,6 +68,9 @@ func TestStartContinuesInBackground(t *testing.T) { | |||
| } | |||
| b := WithClients(cl, dcl, cl) | |||
|
|
|||
| fmt.Println(viper.IsSet("auth-delegator-available")) | |||
| fmt.Println(viper.GetBool("auth-delegator-available")) | |||
| @@ -85,7 +88,7 @@ func TestStartContinuesInBackground(t *testing.T) { | |||
| select { | |||
| case <-done: | |||
| assert.False(t, viper.GetBool("auth-delegator-available")) | |||
| case <-time.After(1 * time.Second): | |||
| case <-time.After(5 * time.Second): | |||
There was a problem hiding this comment.
here we changed it from 1 to 5 s and in the next pr we change it back to 1s? seems weird to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Note: this work needs to be done for other settings too but will be done in follow-up PRs