Workaround antd v3 error in the production build #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that the antd v3 upgrade in cda1746 causes an error in the production build, apparently due to a bad interplay with vite/esbuild bundling. As a workaround, provide an import alias for the antd icon sprite file that's causing the issue.[1] --- [1] ant-design/ant-design#19002 (comment) Signed-off-by: Máté Szabó <[email protected]>
mszabo-wikia
requested review from
everett980,
rubenvp8510 and
tiffon
as code owners
1 task
yurishkuro
approved these changes
Mar 15, 2023
|
As far as I see, #1261 will remove the need for this workaround, since that will switch icons to use individual imports rather than a central sprite with all icons. I'll make a point to test the production build case with that to determine whether the workaround can be removed then. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1276 +/- ##
=======================================
Coverage 95.35% 95.35%
=======================================
Files 244 244
Lines 7753 7753
Branches 2016 2016
=======================================
Hits 7393 7393
Misses 360 360 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Thanks for quick fix |
|
You're welcome, sorry about the issue :) |
Katarzyna-B
pushed a commit
to vervegroup/jaeger-ui
that referenced
this pull request
Mar 20, 2023
## Which problem is this PR solving? - Unbreak the UI in the production build (closes jaegertracing#1275) ## Short description of the changes It seems that the antd v3 upgrade in cda1746 causes an error in the production build, apparently due to a bad interplay with vite/esbuild bundling. As a workaround, provide an import alias for the antd icon sprite file that's causing the issue.[1] --- [1] ant-design/ant-design#19002 (comment) Signed-off-by: Máté Szabó <[email protected]>
Binrix
pushed a commit
to Binrix/jaeger-ui
that referenced
this pull request
Apr 18, 2023
## Which problem is this PR solving? - Unbreak the UI in the production build (closes jaegertracing#1275) ## Short description of the changes It seems that the antd v3 upgrade in cda1746 causes an error in the production build, apparently due to a bad interplay with vite/esbuild bundling. As a workaround, provide an import alias for the antd icon sprite file that's causing the issue.[1] --- [1] ant-design/ant-design#19002 (comment) Signed-off-by: Máté Szabó <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
It seems that the antd v3 upgrade in
cda1746 causes an error in the production build, apparently due to a bad interplay with vite/esbuild bundling. As a workaround, provide an import alias for the antd icon sprite file that's causing the issue.[1]
[1] ant-design/ant-design#19002 (comment)