Remove lerna dependency #1997
Merged
Remove lerna dependency #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerna/nx does not support s390x: https://github.com/nrwl/nx/blob/16.6.0/packages/nx/src/native/index.js#L161 https://github.com/nrwl/nx/blob/16.6.0/docs/shared/installation/troubleshoot-installation.md#supported-native-module-platforms Resolves: jaegertracing#1996 Resolves: jaegertracing#341 Signed-off-by: Andreas Gerstmayr <[email protected]>
andreasgerstmayr
requested review from
pavolloffay
and removed request for
a team
Signed-off-by: Andreas Gerstmayr <[email protected]>
frzifus
approved these changes
Nov 22, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1997 +/- ##
=======================================
Coverage 96.54% 96.54%
=======================================
Files 256 256
Lines 7604 7604
Branches 1978 1978
=======================================
Hits 7341 7341
Misses 263 263 ☔ View full report in Codecov by Sentry. |
yurishkuro
added
changelog:dependencies
albertteoh
added
changelog:dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
lerna/nx does not support s390x, and therefore the jaeger-ui build fails on this platform. This PR removes the lerna dependency from jaeger-ui.
https://github.com/nrwl/nx/blob/16.6.0/packages/nx/src/native/index.js#L161
https://github.com/nrwl/nx/blob/16.6.0/docs/shared/installation/troubleshoot-installation.md#supported-native-module-platforms
Resolves: #1996
Resolves: #341
Description of the changes
Remove
lernaand useyarn workspacesinstead.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test