-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gracefully handle spans without logs field #2191
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2191 +/- ##
==========================================
+ Coverage 96.57% 96.59% +0.01%
==========================================
Files 254 254
Lines 7629 7629
Branches 1925 1988 +63
==========================================
+ Hits 7368 7369 +1
+ Misses 261 260 -1 ☔ View full report in Codecov by Sentry. |
also, DCO check is still failing (easiest is to squash commits and resubmit just one as signed) |
btw the reason DCO is failing is because it looks like you have different emails in github account and your local git config |
Otherwise, search fails with: Uncaught TypeError: Cannot read properties of undefined (reading 'some') Signed-off-by: Maxim.Kolmakov <[email protected]>
Sorry for the mess, and thank you for your patience; I fixed the email address in the repository to match the one in Github and the prettier warning in the test file. |
tip for the future - do not create PRs from the main branch of your fork, always use a new branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Searching of spans throws "Cannot read properties of undefined (reading 'some')" exceptions and breaks UI
To reproduce:
bootstrap
in searchThe following exception will be thrown and UI will crash completely: