Optimize tree walk to avoid too depth function call stack. #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
==========================================
+ Coverage 83.1% 83.14% +0.04%
==========================================
Files 142 142
Lines 3172 3181 +9
Branches 654 654
==========================================
+ Hits 2636 2645 +9
Misses 429 429
Partials 107 107
Continue to review full report at Codecov.
|
rubenvp8510
force-pushed
the
Issue-320
branch
2 times, most recently
from
3d691f8
to
1f463dc
Compare
tiffon
suggested changes
Feb 13, 2019
Signed-off-by: ruben.vargas <[email protected]>
rubenvp8510
force-pushed
the
Issue-320
branch
from
1f463dc
to
ae3cde4
Compare
Signed-off-by: ruben.vargas <[email protected]>
rubenvp8510
force-pushed
the
Issue-320
branch
from
ae3cde4
to
8b30e0f
Compare
|
Ready for another review :) |
ghost
assigned
tiffon
approved these changes
Feb 21, 2019
Awesome work! Thanks so much for making these changes! 🎉 |
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
…cing#326) * Optimize tree walk Signed-off-by: ruben.vargas <[email protected]> * Add test to treeNode walk function for check depth calculation Signed-off-by: ruben.vargas <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
I did some tests and it seems to behave better with an iterative walk algorithm. This partially solves the problem, because the render of too many components is slow. We could probably need to impose a limit on the depth (But at least now is not freezing anymore)