Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ddg menu item, fetch server ops, expand GA cov #501

Merged
merged 7 commits into from
Dec 19, 2019

Conversation

everett980
Copy link
Collaborator

Short description of the changes

  • Read deepDependencies.menuEnabled from config.json and add Menu link if it is
  • Add link to /deep-dependencies to search results DDG if deepDependencies.menuEnabled is true
  • Only fetch server ops for DDG operations dropdown
  • Add GA tracking for show/expand one/all and for search results to DDG / gantt chart conversions

@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #501 into master will increase coverage by 0.04%.
The diff coverage is 94.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
+ Coverage   92.87%   92.92%   +0.04%     
==========================================
  Files         197      197              
  Lines        4757     4789      +32     
  Branches     1151     1155       +4     
==========================================
+ Hits         4418     4450      +32     
  Misses        298      298              
  Partials       41       41
Impacted Files Coverage Δ
...s/DeepDependencies/Header/LayoutSettings/index.tsx 100% <ø> (ø) ⬆️
packages/jaeger-ui/src/types/index.tsx 0% <ø> (ø) ⬆️
...i/src/components/DeepDependencies/Header/index.tsx 100% <ø> (ø) ⬆️
packages/jaeger-ui/src/api/jaeger.js 100% <100%> (ø) ⬆️
packages/jaeger-ui/src/reducers/services.js 100% <100%> (+15.38%) ⬆️
...nents/SearchTracePage/SearchResults/ResultItem.tsx 87.5% <100%> (+0.83%) ⬆️
packages/jaeger-ui/src/actions/jaeger-api.js 100% <100%> (ø) ⬆️
...s/SearchTracePage/SearchResults/AltViewOptions.tsx 100% <100%> (ø) ⬆️
...aeger-ui/src/components/DeepDependencies/index.tsx 100% <100%> (ø) ⬆️
.../SearchTracePage/SearchResults/ResultItemTitle.tsx 100% <100%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d02881b...d46d48e. Read the comment docs.

@everett980 everett980 merged commit 135ccfe into jaegertracing:master Dec 19, 2019
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
* Temp: Default link visible with banner

Signed-off-by: Everett Ross <[email protected]>

* WIP: Use server ops in ddg, track conv&collapse

Signed-off-by: Everett Ross <[email protected]>

* Add tests

Signed-off-by: Everett Ross <[email protected]>

* Remove DDG announcement banner

Signed-off-by: Everett Ross <[email protected]>

* Remove default ddg.menuEnabled

Signed-off-by: Everett Ross <[email protected]>

* Add ddg.menuEnabled to types/config

Signed-off-by: Everett Ross <[email protected]>

Signed-off-by: vvvprabhakar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants