Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable deadlock detector interval for ingester. #1133

Closed
wants to merge 1 commit into from
Closed

Configurable deadlock detector interval for ingester. #1133

wants to merge 1 commit into from

Conversation

marqc
Copy link
Contributor

@marqc marqc commented Oct 22, 2018

Which problem is this PR solving?

Short description of the changes

  • Additional configurable flag for ingester deadlock detector interval
  • Value of 0 disables deadlock_detector

…bles deadlock_detector. #issue1225

Signed-off-by: Marek Chodor <[email protected]>
@codecov
Copy link

codecov bot commented Oct 22, 2018

Codecov Report

Merging #1133 into master will decrease coverage by 0.13%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1133      +/-   ##
==========================================
- Coverage     100%   99.86%   -0.14%     
==========================================
  Files         142      142              
  Lines        6743     6758      +15     
==========================================
+ Hits         6743     6749       +6     
- Misses          0        3       +3     
- Partials        0        6       +6
Impacted Files Coverage Δ
cmd/ingester/app/consumer/consumer.go 100% <100%> (ø) ⬆️
cmd/ingester/app/flags.go 91.66% <66.66%> (-8.34%) ⬇️
cmd/ingester/app/consumer/deadlock_detector.go 92.94% <70%> (-7.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a07b78...fead1c3. Read the comment docs.

@marqc marqc closed this Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant