Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support secure gRPC channel between agent and collector #1391

Merged

Conversation

yurishkuro
Copy link
Member

Extends PR #1311 (which was in ghouscht:master, hard to add to directly)

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #1391 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1391   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         164     164           
  Lines        7460    7488   +28     
======================================
+ Hits         7460    7488   +28
Impacted Files Coverage Δ
cmd/collector/app/builder/builder_flags.go 100% <100%> (ø) ⬆️
cmd/agent/app/reporter/grpc/collector_proxy.go 100% <100%> (ø) ⬆️
cmd/agent/app/reporter/grpc/flags.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3835b4...471d434. Read the comment docs.

@yurishkuro yurishkuro changed the title Secure grpc agent to collector Support secure gRPC channel between agent and collector Feb 28, 2019
Signed-off-by: Yuri Shkuro <[email protected]>
Copy link
Member

@tiffon tiffon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:stamp:

@yurishkuro yurishkuro merged commit 9f0551d into jaegertracing:master Mar 1, 2019
@ghost ghost removed the review label Mar 1, 2019
@yossishm
Copy link

yossishm commented May 11, 2019

Hi,
A Q?
On which Jaeger Collector/Agent version is this issue resolved? (I use latest - 1.11)

I configured a tls on p 14250 between Agent and Collector and Using a wireshark container sniffing I can see the spans which means they aren't encrypted (Did the same TLS checkup on Collector to elastic and data was encrypted).

Attaching sniffing snapshot.

Jaeger-Sniffing

Thanks,
Y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants