Allow thrift reporter even if grpc hosts are not provided #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <[email protected]>
pavolloffay
requested review from
black-adder,
jpkrohling,
objectiser,
tiffon,
vprithvi and
yurishkuro
as code owners
ghost
assigned Signed-off-by: Pavol Loffay <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1400 +/- ##
======================================
Coverage 100% 100%
======================================
Files 164 164
Lines 7488 7502 +14
======================================
+ Hits 7488 7502 +14
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Mar 4, 2019
| assert.Nil(t, proxy) | ||
| } else { | ||
| require.NoError(t, err) | ||
| proxy.GetReporter().EmitBatch(jaeger.NewBatch()) |
There was a problem hiding this comment.
Where is the batch being sent?
There was a problem hiding this comment.
nowhere I just need metrics to log it
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1395
Signed-off-by: Pavol Loffay [email protected]