Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade grpc to 1.20.1 #1492

Merged
merged 2 commits into from
Apr 24, 2019
Merged

upgrade grpc to 1.20.1 #1492

merged 2 commits into from
Apr 24, 2019

Conversation

guanw
Copy link
Contributor

@guanw guanw commented Apr 24, 2019

Signed-off-by: Jude Wang [email protected]

Which problem is this PR solving?

Short description of the changes

  • Upgrade grpc to 1.20.1

Signed-off-by: Jude Wang <[email protected]>
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, assuming tests pass

@guanw
Copy link
Contributor Author

guanw commented Apr 24, 2019

crossdock seems to be flaky again?

@yurishkuro
Copy link
Member

it doesn't get to that point, something failing in constructing python image. I kicked it off again.

@yurishkuro
Copy link
Member

It's failing on building cassandra schema image

docker build -t jaegertracing/jaeger-cassandra-schema:latest plugin/storage/cassandra/

    Installed /tmp/pip-install-6wlzdxrv/elasticsearch-curator/.eggs/urllib3-1.25.1-py3.7.egg
    Traceback (most recent call last):
      File "/tmp/pip-install-6wlzdxrv/elasticsearch-curator/setup.py", line 37, in <module>
        from cx_Freeze import setup, Executable
    ModuleNotFoundError: No module named 'cx_Freeze'

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #1492 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1492   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files         181      181           
  Lines        8651     8651           
=======================================
  Hits         8635     8635           
  Misses          8        8           
  Partials        8        8
Impacted Files Coverage Δ
cmd/agent/app/reporter/grpc/builder.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d239ae...6affdef. Read the comment docs.

@yurishkuro yurishkuro merged commit 7a1f334 into jaegertracing:master Apr 24, 2019
@yurishkuro yurishkuro mentioned this pull request Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants