Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sampler type tag to collector ingestion metrics #1576

Merged
merged 9 commits into from
Jun 6, 2019
Merged

Add sampler type tag to collector ingestion metrics #1576

merged 9 commits into from
Jun 6, 2019

Conversation

guanw
Copy link
Contributor

@guanw guanw commented May 31, 2019

Which problem is this PR solving?

Short description of the changes

  • This pull request adds new tag representing sampler types to metrics

@black-adder black-adder changed the title adding sampler type tag to metrics Add sampler type tag to collector ingestion metrics May 31, 2019
cmd/collector/app/metrics.go Outdated Show resolved Hide resolved
cmd/collector/app/metrics.go Outdated Show resolved Hide resolved
model/span.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #1576 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1576      +/-   ##
=========================================
+ Coverage    98.8%   98.8%   +<.01%     
=========================================
  Files         191     191              
  Lines        9102    9116      +14     
=========================================
+ Hits         8993    9007      +14     
  Misses         85      85              
  Partials       24      24
Impacted Files Coverage Δ
cmd/collector/app/metrics.go 100% <100%> (ø) ⬆️
model/span.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d994244...e7f9abb. Read the comment docs.

@jpkrohling
Copy link
Contributor

If we have one service, "hotrod", deployed in two hosts/pods, each with a different sampler (const, ratelimiting), we'd then end up with two metrics, right?

What's the impact of this PR on people who are using the previous version of this metric?

@black-adder
Copy link
Contributor

What's the impact of this PR on people who are using the previous version of this metric?

Depending on how users have setup their dashboards, users may see the service.traces.received and service.spans.received metrics now split by the sampler_type label. But if users have metrics setup like: sum(service.traces.received) by (svc, debug, format) then they should see no difference as the two new metrics will be summed.

@yurishkuro
Copy link
Member

Do we need to be changing service.spans.received? Sampler is only defined on the root span and that's what traces.received metric is already capturing.

@guanw
Copy link
Contributor Author

guanw commented Jun 3, 2019

Do we need to be changing service.spans.received? Sampler is only defined on the root span and that's what traces.received metric is already capturing.

Yeah you're right. The samplerType metric will only be applied to trace.received. For spans.received it will simply pass.

model/span_test.go Outdated Show resolved Hide resolved
@guanw
Copy link
Contributor Author

guanw commented Jun 3, 2019

@yurishkuro is there anyway to debug travis ci test failure? make test-ci runs fine on my local setup and I couldn't reproduce the error by manually running L11-16 of build-all-in-one-image.sh locally either. (As quoted by Won: Best kind of bug)

@yurishkuro
Copy link
Member

don't know if you can debug it, but the log output suggests a timeout - #1583

cmd/collector/app/metrics.go Outdated Show resolved Hide resolved
cmd/collector/app/metrics.go Outdated Show resolved Hide resolved
cmd/collector/app/metrics.go Outdated Show resolved Hide resolved
Jude Wang added 7 commits June 5, 2019 10:45
Signed-off-by: Jude Wang <[email protected]>
Signed-off-by: Jude Wang <[email protected]>
Signed-off-by: Jude Wang <[email protected]>
Signed-off-by: Jude Wang <[email protected]>
Signed-off-by: Jude Wang <[email protected]>
Signed-off-by: Jude Wang <[email protected]>
@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #1576 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1576      +/-   ##
==========================================
+ Coverage    98.8%   98.81%   +<.01%     
==========================================
  Files         191      191              
  Lines        9095     9162      +67     
==========================================
+ Hits         8986     9053      +67     
  Misses         85       85              
  Partials       24       24
Impacted Files Coverage Δ
cmd/collector/app/metrics.go 100% <100%> (ø) ⬆️
model/span.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09dad38...6eeae79. Read the comment docs.

cmd/collector/app/metrics.go Outdated Show resolved Hide resolved
cmd/collector/app/metrics.go Outdated Show resolved Hide resolved
Jude Wang added 2 commits June 5, 2019 11:39
Signed-off-by: Jude Wang <[email protected]>
Signed-off-by: Jude Wang <[email protected]>
@black-adder black-adder merged commit 7f2a49d into jaegertracing:master Jun 6, 2019
@guanw guanw mentioned this pull request Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants