Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use credentials when describing keyspaces in cassandra schema builder #1655

Merged

Conversation

MiLk
Copy link
Contributor

@MiLk MiLk commented Jul 5, 2019

This follows #1635 in order to solve jaegertracing/jaeger-operator#469

Which problem is this PR solving?

  • The cassandra-schema-builder is not using the provided credentials when trying to connect to cassandra to know if it's up.

Short description of the changes

  • The query describing the keyspaces (used to wait for cassandra) will use the credentials if any is provided.

@MiLk MiLk force-pushed the credentials-cassandra-schema-builder branch from 64cc7a3 to efeb56c Compare July 5, 2019 08:41
@yurishkuro yurishkuro merged commit 65c8e56 into jaegertracing:master Jul 5, 2019
@MiLk MiLk deleted the credentials-cassandra-schema-builder branch July 6, 2019 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants